[Kde-pim] Review Request: Use colors from current color scheme

[Thomas McGuire]

> On 2009-11-11 13:53:02, Thomas McGuire wrote:
> > Pink!? Then I object the patch, please find a better color role that matches blue and red more closely, with the default color scheme.
> > 
> > Other than that, KMail also needs to be changed, same situation there.
> > Since KMail doesn't use KConfigXT, the default colors are set in many places there:
> > StorageModel::Private::loadSettings() in kdepim/messagelist/storagemodel.cpp
> > AppearancePage::ColorsTab::doLoadOther() in kdepim/kmail/configuredialog.cpp
> > StorageModel::StorageModel() in kdepim/kmail/messagelistview/storagemodel.cpp
> 
> Christoph Feck wrote:
>     Red color would be the "negative" role, but I don't see anything "negative" in "new" messages, except maybe "do not miss me!" :) Please decide.
>     
>     The color scheme itself could also be changed to make the color a bit darker, something like purple would look good. I am even willing to file a bug report for Oxygen :)
>     
>     And I have not looked at KMail yet, I just stumbled on mentioned BR while browsing bko.
> 
> Markus Slopianka wrote:
>     Sorry, but your objection is illogical. It's not the patch's fault that "new" is pink. It's Oxygen's fault.
>     I can't comment about the patch quality itself, but the overall cause is good. If the patch quality is good, I'd like to see it submitted along with a patch for Oxygen that changes pink to blue, green, orange or whatever.

Right now the patch (mis-)uses the color roles "LinkText" and "ActiveText". They don't really map to new and unread. Why not create new color roles in kdelibs for that? Then the colors for that could have sane defaults as well, instead of trying random color roles that happen to look a bit blue and reddish :)

Disclaimer: I'm neither an Akregator developer nor a color expert.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2131/#review3026
-----------------------------------------------------------


On 2009-11-10 19:29:01, Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2131/
> -----------------------------------------------------------
> 
> (Updated 2009-11-10 19:29:01)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Unless configured otherwise, Akregator uses hardcoded red and blue colors for new and unread articles. This patch changes the default colors to use the recommended colors from the current color scheme.
> 
> The only problem is that with current default color theme (Oxygen), the "new/active" text is a somewhat bright pink, which does not contrast well on the white background.
> 
> 
> This addresses bug 207860.
>     https://bugs.kde.org/show_bug.cgi?id=207860
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/akregator/src/articlelistview.cpp 1047245 
> 
> Diff: http://reviewboard.kde.org/r/2131/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/