[Kde-pim] Review Request: Use colors from current color scheme

[Sebastian Kügler]

On Thursday 12 November 2009 10:35:15 Markus Slopianka wrote:
> > On 2009-11-11 13:53:02, Thomas McGuire wrote:
> > > Pink!? Then I object the patch, please find a better color role that
> > > matches blue and red more closely, with the default color scheme. 
> > > Other than that, KMail also needs to be changed, same situation there.
> > > Since KMail doesn't use KConfigXT, the default colors are set in many
> > > places there: StorageModel::Private::loadSettings() in
> > > kdepim/messagelist/storagemodel.cpp
> > > AppearancePage::ColorsTab::doLoadOther() in
> > > kdepim/kmail/configuredialog.cpp StorageModel::StorageModel() in
> > > kdepim/kmail/messagelistview/storagemodel.cpp
> >
> > 
> > Christoph Feck wrote:
> >     Red color would be the "negative" role, but I don't see anything
> > "negative" in "new" messages, except maybe "do not miss me!" :) Please
> > decide. 
> >     The color scheme itself could also be changed to make the color a bit
> > darker, something like purple would look good. I am even willing to file
> > a bug report for Oxygen :) 
> >     And I have not looked at KMail yet, I just stumbled on mentioned BR
> > while browsing bko.
> 
> Sorry, but your objection is illogical. It's not the patch's fault that
>  "new" is pink. It's Oxygen's fault. I can't comment about the patch
>  quality itself, but the overall cause is good. If the patch quality is
>  good, I'd like to see it submitted along with a patch for Oxygen that
>  changes pink to blue, green, orange or whatever.

For color-blind people this is a non-starter anyway. I'd suggest using bold for 
unread and normal-weight for read messages.

Removing hard-coded colors is always a good thing.
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/