[Kde-pim] Review Request: kolabproxyresource.cpp:404: warning: unused variable 'job'

[Guy Maurel]

> On 2009-11-20 16:34:00, Stephen Kelly wrote:
> > Please create a new patch which satisfies the TODOs and uses slots connected to the result signals of the jobs, checks for errors, and calls the appropriate methods there.
> > 
> > eg: (not tested)
> > 
> > connect(modifyJob, SIGNAL(result(KJob *)), SLOT(slotModifyComplete(KJob *)));
> > 
> > Resource::slotModifyComplete(KJob *job)
> > {
> >   if (job->error())
> >   {
> >     kDebug() << job->errorString();
> >     cancelTask();
> >     return;
> >   }
> >   changeCommitted();
> > }
> > 
> >

OK, thanks for the example.
see: kolabproxyresource-gm-65-b.diff


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2172/#review3191
-----------------------------------------------------------


On 2009-11-26 20:18:47, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2172/
> -----------------------------------------------------------
> 
> (Updated 2009-11-26 20:18:47)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp:404: warning: unused variable 'job'
> /.../kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp:420: warning: unused variable 'job'
> /.../kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp:499: warning: unused variable 'job'
> /.../kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp:552: warning: unused variable 'job'
> 
> my proposal: in the four functions, the variable is only declared and get some memory: is it realy
>              necessary?
>              If not, one can delete the lines
> see: kolabproxyresource-gm-65.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/akonadi/resources/kolabproxy/kolabproxyresource.h 1053258 
>   /trunk/KDE/kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp 1053258 
> 
> Diff: http://reviewboard.kde.org/r/2172/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/