[Kde-pim] Review Request: kolabproxyresource.cpp:404: warning: unused variable 'job'

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2172/#review3310
-----------------------------------------------------------



/trunk/KDE/kdepim/akonadi/resources/kolabproxy/kolabproxyresource.h
<http://reviewboard.kde.org/r/2172/#comment2594>

    method names never start with upper case.
    



/trunk/KDE/kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp
<http://reviewboard.kde.org/r/2172/#comment2591>

    I think to should move to the result slot as well.
    Basically the success case of the result



/trunk/KDE/kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp
<http://reviewboard.kde.org/r/2172/#comment2593>

    I am not sure this needs a cancelTask().
    It sounds like the job is triggered by a change from the IMAP side, not a change from Akonadi side



/trunk/KDE/kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp
<http://reviewboard.kde.org/r/2172/#comment2592>

    not sure about this one, the comment says we don't care.
    


- Kevin


On 2009-11-26 20:18:47, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2172/
> -----------------------------------------------------------
> 
> (Updated 2009-11-26 20:18:47)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp:404: warning: unused variable 'job'
> /.../kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp:420: warning: unused variable 'job'
> /.../kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp:499: warning: unused variable 'job'
> /.../kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp:552: warning: unused variable 'job'
> 
> my proposal: in the four functions, the variable is only declared and get some memory: is it realy
>              necessary?
>              If not, one can delete the lines
> see: kolabproxyresource-gm-65.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/akonadi/resources/kolabproxy/kolabproxyresource.h 1053258 
>   /trunk/KDE/kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp 1053258 
> 
> Diff: http://reviewboard.kde.org/r/2172/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/