[Kde-pim] Review Request: a typo? certificateselectiondialog.cpp:146: warning: unused variable 'cancel'

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2175/#review3296
-----------------------------------------------------------

Ship it!


- Stephen


On 2009-11-25 17:42:59, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2175/
> -----------------------------------------------------------
> 
> (Updated 2009-11-25 17:42:59)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/kleopatra/dialogs/certificateselectiondialog.cpp:146: warning: unused variable 'cancel'
> 
> at
> class CertificateSelectionDialog::Private
> 
> my proposal: It could be a typo at line 156:
>                connect( &buttonBox, SIGNAL(rejected()), q, SLOT(reject()) );
>              which migth be:
>                connect( cancel, SIGNAL(rejected()), q, SLOT(reject()) );
>              what thinks the developper of it?
> 
> see: certificateselectiondialog-gm-68.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kleopatra/dialogs/certificateselectiondialog.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2175/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/