[Kde-pim] Review Request: eventloopinteractor.cpp:52: warning: suggest explicit braces to avoid ambiguous 'else'

[Guy Maurel]

> On 2009-11-10 22:06:19, Stephen Kelly wrote:
> > /trunk/KDE/kdepimlibs/qgpgme/eventloopinteractor.cpp, line 57
> > <http://reviewboard.kde.org/r/2128/diff/1/?file=14324#file14324line57>
> >
> >     Removing this is not the correct fix. The if() block is compiled conditionally. To supress the warning you need a brace after if ( !mSelf ) and before return mSelf.

OK. It was a little bit difficult to read, because the line (void)new... changes the block, depending of the conditional compilation.


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2128/#review3006
-----------------------------------------------------------


On 2009-11-11 18:07:15, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2128/
> -----------------------------------------------------------
> 
> (Updated 2009-11-11 18:07:15)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> /.../kdepimlibs/qgpgme/eventloopinteractor.cpp:52: warning: suggest explicit braces to avoid ambiguous 'else'
> 
> at
> QGpgME::EventLoopInteractor::instance
> 
> my proposal:
> The 'else'-block is empty. I propose to delete it.
> see: eventloopinteractor-gm-50.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/qgpgme/eventloopinteractor.cpp 1045694 
> 
> Diff: http://reviewboard.kde.org/r/2128/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/