[Kde-pim] Review Request: Add Geo tag support and fix the multihash problem

[Sergio Martins]

> On 2009-04-18 06:08:46, Allen Winter wrote:
> > Update.  The Geo part of this patch has been committed.  The fix for the multihash problem is not binary compatible, so I wonder if you can provide a new patch using the technique shown at http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++#Adding_new_virtual_functions_to_leaf_classes
> > 
> > If you can, please provide a new patch without any of the Geo code as that is no longer needed.
> 
> Sergio Martins wrote:
>     From http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++:
>     
>     """
>     You can...
>         * add new non-virtual functions including signals and slots and constructors. 
>     """
>     
>     So I think it's ok, but i didn't look at it very closely, must run, be back Sunday to review better :)

oh, incidenceUpdate() is virtual


- Sergio


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/495/#review954
-----------------------------------------------------------


On 2009-04-01 04:27:03, Csaba Kertész wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/495/
> -----------------------------------------------------------
> 
> (Updated 2009-04-01 04:27:03)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The patch solves two situation:
> 
> 1. It adds support for the Geo field of the iCalendar which was missing so far.
> 2. Event/note start/end time changes caused duplicates in the CalendarLocal hashes. The bug is easy to detect by
> patching only tests/testcalendarlocal.cpp (and .h) and trying the new test with old KCal.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kcal/alarm.cpp 947746 
>   trunk/KDE/kdepimlibs/kcal/calendarlocal.h 947746 
>   trunk/KDE/kdepimlibs/kcal/calendarlocal.cpp 947746 
>   trunk/KDE/kdepimlibs/kcal/event.cpp 947746 
>   trunk/KDE/kdepimlibs/kcal/freebusy.cpp 947746 
>   trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 947746 
>   trunk/KDE/kdepimlibs/kcal/incidence.h 947746 
>   trunk/KDE/kdepimlibs/kcal/incidence.cpp 947746 
>   trunk/KDE/kdepimlibs/kcal/incidencebase.h 947746 
>   trunk/KDE/kdepimlibs/kcal/incidencebase.cpp 947746 
>   trunk/KDE/kdepimlibs/kcal/tests/testcalendarlocal.h 947746 
>   trunk/KDE/kdepimlibs/kcal/tests/testcalendarlocal.cpp 947746 
>   trunk/KDE/kdepimlibs/kcal/todo.cpp 947746 
> 
> Diff: http://reviewboard.kde.org/r/495/diff
> 
> 
> Testing
> -------
> 
> Written unit test case to verify the fix.
> 
> 
> Thanks,
> 
> Csaba
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/