[Kde-pim] Review Request: Fix for kcal's Recurrence::timesInInterval() when events have RDATES and but don't have RRULES

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/651/#review1026
-----------------------------------------------------------

Ship it!


Great job, as usual.  I would also ask you to run 'make test' in kcal, just to be sure this patch doesn't break anything else.


trunk/KDE/kdepimlibs/kcal/recurrence.cpp
<http://reviewboard.kde.org/r/651/#comment700>

    please rewrite this comment to be a bit more comprehensible.


- Allen


On 2009-05-01 14:04:44, Sergio Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/651/
> -----------------------------------------------------------
> 
> (Updated 2009-05-01 14:04:44)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Fixes two problems with Recurrence::timesInInterval( start, end ) that are only reproducible with events from lotus notes.
> 
> timesInInterval() was returning all dates in mRDates and mRDateTimes regardless if they belonged to the interval [start, end].
> 
> If the event had rdates but didn't have rrules, the first occurrence (the one specified by dtstart) wasn't returned.
> 
> 
> This addresses bug 191221.
>     https://bugs.kde.org/show_bug.cgi?id=191221
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kcal/recurrence.cpp 955540 
> 
> Diff: http://reviewboard.kde.org/r/651/diff
> 
> 
> Testing
> -------
> 
> Tested event from bug 191221. Tested recurring events created with korganizer.
> 
> 
> Thanks,
> 
> Sergio
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/