[Kde-pim] Review Request: Warn user filter without actions is invalid

Jonathan Armond jon.armond at gmail.com
Tue May 26 07:18:44 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/761/
-----------------------------------------------------------

(Updated 2009-05-25 23:18:42.635761)


Review request for KDE PIM.


Changes
-------

Don't complain about missing actions, only about missing matching pattern or missing accounts.


Summary
-------

Current behaviour is to complain when saving a filter with no matching pattern, but having no action is allowed. This patch changes it complain if no action is specified or no matching pattern or, if applicable, no accounts are selected.


This addresses bug 182581.
    https://bugs.kde.org/show_bug.cgi?id=182581


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/kmfilter.cpp 972508 

Diff: http://reviewboard.kde.org/r/761/diff


Testing
-------


Thanks,

Jonathan

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list