[Kde-pim] Review Request: Warn user filter without actions is invalid

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/761/#review1205
-----------------------------------------------------------

Ship it!


Looks ok, please commit (except the minor coding style issue below, fix that first)
Thanks!


/trunk/KDE/kdepim/kmail/kmfilter.cpp
<http://reviewboard.kde.org/r/761/#comment761>

    Coding Style: Change "((" to "( (" please


- Thomas


On 2009-05-25 23:18:42, Jonathan Armond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/761/
> -----------------------------------------------------------
> 
> (Updated 2009-05-25 23:18:42)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Current behaviour is to complain when saving a filter with no matching pattern, but having no action is allowed. This patch changes it complain if no action is specified or no matching pattern or, if applicable, no accounts are selected.
> 
> 
> This addresses bug 182581.
>     https://bugs.kde.org/show_bug.cgi?id=182581
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmfilter.cpp 972508 
> 
> Diff: http://reviewboard.kde.org/r/761/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/