[Kde-pim] Review Request: Fixing kaddressbook export for GMX

[Urs Joss]

> On 2009-05-13 16:18:22, Allen Winter wrote:
> > Feel free to commit this.

Hi Allan

This is my first contribution here and I'm not sure if you're directing the 'go' to me or not. Just in case: I don't have commit permissions and would have to rely on somebody who does have them to get this patch into trunk.

Cheers
Urs


- Urs


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/693/#review1122
-----------------------------------------------------------


On 2009-05-13 07:09:08, Urs Joss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/693/
> -----------------------------------------------------------
> 
> (Updated 2009-05-13 07:09:08)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> GMX must have changed the structure of the files used for importing addressses into the GMX addressbook. When you export from kaddressbook for GMX and import the file there, the work and home addresses are swapped.
> 
> The patch for review swaps work and home address ID in the code. It assigns ID 1 (instead of 0) to the work address.
> 
> This review is related to bug 145325 in the KDE bugtracker.
> 
> 
> This addresses bug 145325.
>     https://bugs.kde.org/show_bug.cgi?id=145325
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kaddressbook/xxport/gmx_xxport.cpp 967490 
> 
> Diff: http://reviewboard.kde.org/r/693/diff
> 
> 
> Testing
> -------
> 
> I have initially created the patch for Gentoo Linux (still for KDE 3.5.10 I believe, reapplying the patch for all subsequent releases of KDE) and have successfully uploaded addresses into GMX since.
> 
> There is probably more potential for optimizing the GMX export, but I didn't get to that yet. The current patch fixes the most obvious issue IMHO.
> 
> 
> Thanks,
> 
> Urs
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/