[Kde-pim] Review Request: Polishing: icons for context menus, sortable identity list

[Thomas McGuire]

Hi,

On Sunday 08 March 2009 21:04:49 Ingo Klöcker wrote:
> On Sunday 08 March 2009, Thomas McGuire wrote:
> > On Sunday 08 March 2009 12:53:30 Ingo Klöcker wrote:
> > > > Enable sorting of identity list in the preferences
> > > >     - Incoming and outgoings accounts are sortable too,
> > > >       why not this one? (I'm always confused because
> > > >       my identities are not sorted)
> > >
> > > The identities used to be sorted alphabetically in KDE 3 with the
> > > exception that the default identity was always listed first. Since
> > > the order of the identities influences the mechanism choosing an
> > > identity to use for a reply it makes sense to allow sorting. So I'm
> > > in favor of this change.
> >
> > The order of the identities in the GUI dialog influence reply
> > behavior? Where in the code is that and how does that work? That
> > seems unintuitive to me, especially because the order can't be
> > changed (the patch doesn't change that, it just enables GUI sorting
> > by clicking the header of the listview).
>
> Ah, it only changes the order in the GUI. The order of the identities in
> the GUI dialog does not influence reply behavior. Sorry, for the
> confusion.
>
> The order of identities in IdentityManager (which atm is the order of
> creation) is only important if several identities have the same email
> address which I guess isn't the common use case.
>
> The relevant code is
> KPIMIdentities::IdentityManager::identityForAddress() called by
> KMMessage::identityUoid() (<- this is the interesting method) called by
> KMMessage::initFromMessage() called by
> KMMessage::createReply()

Ingo, thanks for pointing this out. I didn't think of the case of identities 
with the same mail address at all. In this case, the preferred reply identity 
is indeed dependant on the identity creation order. As this is a corner case, 
I don't think it is really worth doing something about this.

Regards,
Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20090309/e11069e7/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/