[Kde-pim] Review Request: Implementation for RecurrenceRule::operator=()

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/260/#review430
-----------------------------------------------------------

Ship it!


Looks fine to me.

I can't help thinking that mConstraints etc. could be more efficiently copied instead of recalculated in both the copy constructor and assignment operator, but that's a separate issue.

- David


On 2009-03-08 14:42:57, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/260/
> -----------------------------------------------------------
> 
> (Updated 2009-03-08 14:42:57)
> 
> 
> Review request for KDE PIM and David Jarvie.
> 
> 
> Summary
> -------
> 
> Basically copy&paste of the things done by the existing copy constructor.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/kcal/recurrencerule.cpp 936888 
> 
> Diff: http://reviewboard.kde.org/r/260/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/