[Kde-pim] Review Request: KMail: Polishing - icons for context menus, sortable identity list

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/253/#review409
-----------------------------------------------------------

Ship it!


Thanks, I like shiny icons :)
Committed in r936954, I'll probably backport it to KDE 4.2.2.
Please mark this review request as submitted.

- Thomas


On 2009-03-07 18:57:41, nik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/253/
> -----------------------------------------------------------
> 
> (Updated 2009-03-07 18:57:41)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Hiya!
> 
> Some simple polishing:
> 
> ------------------------------
> Context-Menu of a message:
>     "Copy To", "Move To"
>         - these sub menus use the icons of the folderview
> 
> Context-Menu of a folder:
>     "Copy Folder To"
>         - these sub menus use the icons of the folderview
>         - above entry "Copy to This Folder"
>           (e.g. in "Copy Folder To" -> "Local Folders")
>           is now a separator
> 
> Context-Menu of a URL in the messsage viewer:
>     - Entry "Open URL" now uses the "document-open"
>       icon (like klinkstatus)
> 
>       Note: "Save Links As..." is left without an icon.
>             khtml does not use any icon for this kind of
>             entry, too.
> 
> Enable sorting of identity list in the preferences
>     - Incoming and outgoings accounts are sortable too,
>       why not this one? (I'm always confused because
>       my identities are not sorted)
> ------------------------------
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kmail/identitylistview.cpp 936593 
>   trunk/KDE/kdepim/kmail/kmreaderwin.cpp 936593 
>   trunk/KDE/kdepim/kmail/mainfolderview.cpp 936593 
> 
> Diff: http://reviewboard.kde.org/r/253/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> nik
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/