[Kde-pim] Review Request: KMail composer, automatically remove empty address on changing focus

[Michael Leupold]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/426/
-----------------------------------------------------------

(Updated 2009-03-26 12:37:52.543752)


Review request for KDE PIM.


Changes
-------

Adapt coding style.


Summary
-------

This originates from a discussion after I submitted the patch to allow the clear button in KLineEdits to always be shown to k-c-d.

Aaron suggested empty address lines in the composer could be auto-deleted on leaving the field (editingFinished() signal). I didn't like the idea at first but though I'd give it a try. Here's the outcome, it's actually not bad at all and still feels pretty intuitive. On top of that removing address lines is now easily possible by just hitting Ctrl+A and Del. This would make my previous clear button patch unneccessary for the composer as all empty lines will automatically be removed.

I did one related change: Only change focus if the active line edit is the one being deleted (so no focus change on hitting the clear button on a field you're not currently editing).


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/recipientseditor.h 943961 
  /trunk/KDE/kdepim/kmail/recipientseditor.cpp 943961 

Diff: http://reviewboard.kde.org/r/426/diff


Testing
-------


Thanks,

Michael

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/