[Kde-pim] Review Request: Allow searching by tag

[Ingo Klöcker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/796/#review1274
-----------------------------------------------------------


AFAICS the user has to enter the tag manually. I think it would be more comfortable if the user could select the tag via a combobox (similar to the status combobox). Obviously, this will make things more complicated because one would have to make sure deleted tags that are still used in filters are handled correctly.


/trunk/KDE/kdepim/kmail/kmsearchpattern.cpp
<http://reviewboard.kde.org/r/796/#comment791>

    Please use a foreach-loop. It's not only much less code to write, but it also avoids common pitfalls ("premature pessimization") with using a for-loop for iterating over a list of elements. For example one should evaluate list->end() only once in the initialization of the for-loop, i.e. one should write
    for ( List::const_iterator it = list->begin(), end = list->end(); it != end; ++it ) { ... }
    


- Ingo


On 2009-06-07 06:30:37, Jonathan Armond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/796/
> -----------------------------------------------------------
> 
> (Updated 2009-06-07 06:30:37)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Allow searching messages by tag, and also using tags as a filter criteria. This allows the use of search folders.
> 
> 
> This addresses bugs 136555 and 182279.
>     https://bugs.kde.org/show_bug.cgi?id=136555
>     https://bugs.kde.org/show_bug.cgi?id=182279
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmsearchpattern.h 978277 
>   /trunk/KDE/kdepim/kmail/kmsearchpattern.cpp 978277 
>   /trunk/KDE/kdepim/kmail/kmsearchpatternedit.h 978277 
>   /trunk/KDE/kdepim/kmail/kmsearchpatternedit.cpp 978277 
>   /trunk/KDE/kdepim/kmail/searchjob.cpp 978277 
> 
> Diff: http://reviewboard.kde.org/r/796/diff
> 
> 
> Testing
> -------
> 
> Can search messages by tag. Manually applied filters by tag works.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/