[Kde-pim] Review Request: Allow searching by tag

[Ingo Klöcker]

> On 2009-06-11 08:41:35, Thomas McGuire wrote:
> > /trunk/KDE/kdepim/kmail/rulewidgethandlermanager.cpp, line 1234
> > <http://reviewboard.kde.org/r/796/diff/4/?file=7154#file7154line1234>
> >
> >     Please use names starting with lower case for  variables. Same for TagFunctions.
> 
>  wrote:
>     Was just following the convention in the rest of the file. Shall I fix up the file too?

TagFunctionCount is not a variable but a (static) constant. IMO it is good practice to use upper case for (static) constants in order to differentiate them from variables.


- Ingo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/796/#review1303
-----------------------------------------------------------


On 2009-06-11 07:38:16, Jonathan Armond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/796/
> -----------------------------------------------------------
> 
> (Updated 2009-06-11 07:38:16)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Allow searching messages by tag, and also using tags as a filter criteria. This allows the use of search folders.
> 
> 
> This addresses bugs 136555 and 182279.
>     https://bugs.kde.org/show_bug.cgi?id=136555
>     https://bugs.kde.org/show_bug.cgi?id=182279
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmsearchpattern.h 980307 
>   /trunk/KDE/kdepim/kmail/kmsearchpattern.cpp 980307 
>   /trunk/KDE/kdepim/kmail/kmsearchpatternedit.h 980307 
>   /trunk/KDE/kdepim/kmail/kmsearchpatternedit.cpp 980307 
>   /trunk/KDE/kdepim/kmail/rulewidgethandlermanager.cpp 980307 
>   /trunk/KDE/kdepim/kmail/searchjob.cpp 980307 
> 
> Diff: http://reviewboard.kde.org/r/796/diff
> 
> 
> Testing
> -------
> 
> Can search messages by tag. Manually applied filters by tag works.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/