[Kde-pim] Review Request: Add the posibility for single file resources to add custom pages to the config dialog.

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/828/#review1302
-----------------------------------------------------------

Ship it!


Looks good to me.

- Volker


On 2009-06-11 07:18:41, Bertjan Broeksema wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/828/
> -----------------------------------------------------------
> 
> (Updated 2009-06-11 07:18:41)
> 
> 
> Review request for KDE PIM, Kevin Krammer and Volker Krause.
> 
> 
> Summary
> -------
> 
> Some single file resources might need additional options to the ones available in the single file resource configuration dialog (e.g. lock file method for the mbox resource). This patch adds the possibility to add a custom page without the need of subclassing the SingleFileResourceConfigDialog.
> 
> Example usage:
> 
> SingleFileResourceConfigDialog<Settings> dlg( windowId );
> dlg.addPage( "Lock method", new LockMethodPage() );
> dlg.setCaption( i18n("Select MBox file") );
> if ( dlg.exec() == QDialog::Accepted ) {
> .....
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/akonadi/resources/shared/singlefileresourceconfigdialogbase.h 980331 
>   trunk/KDE/kdepim/akonadi/resources/shared/singlefileresourceconfigdialogbase.cpp 980331 
> 
> Diff: http://reviewboard.kde.org/r/828/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bertjan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/