[Kde-pim] Review Request: Sort template Insert Command menu list

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/809/#review1304
-----------------------------------------------------------

Ship it!


Looks good, please commit. This is not really something that would violate the feature freeze, and the strings are the same.


/trunk/KDE/kdepim/kmail/templatesinsertcommand.cpp
<http://reviewboard.kde.org/r/809/#comment821>

    make this a const QMap &map instead of const QMap map.
    Even though QMap is implicitly shared, I think it would still be a bit faster.


- Thomas


On 2009-06-11 00:43:01, Jonathan Armond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/809/
> -----------------------------------------------------------
> 
> (Updated 2009-06-11 00:43:01)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Template Insert Command menu is currently loosely sorted in English. This patch sorts it according to translated string. Also reduces code duplication.
> 
> 
> This addresses bug 188394.
>     https://bugs.kde.org/show_bug.cgi?id=188394
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/templatesinsertcommand.cpp 979894 
> 
> Diff: http://reviewboard.kde.org/r/809/diff
> 
> 
> Testing
> -------
> 
> Insert Command menu items are sorted and still work.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/