[Kde-pim] Review Request: Improve error message when sending without an account
Thomas McGuire
mcguire at kde.org
Sun Jun 7 18:51:31 BST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/762/#review1279
-----------------------------------------------------------
Ship it!
Looks good to me, except the possible memory leak. Please commit when the string freeze is over!
- Thomas
On 2009-06-07 05:43:38, Jonathan Armond wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/762/
> -----------------------------------------------------------
>
> (Updated 2009-06-07 05:43:38)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> Error message when sending with no outgoing account changed to a question asking whether user wants to create one now. If yes, opens the transport management widget to create outgoing account.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdepim/kmail/kmsender.cpp 978277
> /trunk/KDE/kdepim/kmail/kmcomposewin.cpp 978277
> /trunk/KDE/kdepim/kmail/util.cpp 978277
> /trunk/KDE/kdepimlibs/mailtransport/transportmanager.h 978123
> /trunk/KDE/kdepimlibs/mailtransport/transportmanager.cpp 978123
>
> Diff: http://reviewboard.kde.org/r/762/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jonathan
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list