[Kde-pim] Review Request: Improve error message when sending without an account

[Ingo Klöcker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/762/#review1273
-----------------------------------------------------------

Ship it!


I have spotted a possible memory leak that might need to be addressed. Apart from that the changes are very good.


/trunk/KDE/kdepimlibs/mailtransport/transportmanager.cpp
<http://reviewboard.kde.org/r/762/#comment789>

    const int response = ...
    
    Rationale: Make variables const whenever possible to give people reading the code the hint that the variable will not change its value.



/trunk/KDE/kdepimlibs/mailtransport/transportmanager.cpp
<http://reviewboard.kde.org/r/762/#comment790>

    Is the transport deleted (by whom) if it is not valid?


- Ingo


On 2009-06-07 05:43:38, Jonathan Armond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/762/
> -----------------------------------------------------------
> 
> (Updated 2009-06-07 05:43:38)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Error message when sending with no outgoing account changed to a question asking whether user wants to create one now. If yes, opens the transport management widget to create outgoing account.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmsender.cpp 978277 
>   /trunk/KDE/kdepim/kmail/kmcomposewin.cpp 978277 
>   /trunk/KDE/kdepim/kmail/util.cpp 978277 
>   /trunk/KDE/kdepimlibs/mailtransport/transportmanager.h 978123 
>   /trunk/KDE/kdepimlibs/mailtransport/transportmanager.cpp 978123 
> 
> Diff: http://reviewboard.kde.org/r/762/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/