[Kde-pim] Review Request: Allow searching by tag

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/796/#review1303
-----------------------------------------------------------

Ship it!


Seems fine to me, works nicely, so commit after the freeze.

Only downside that prevents me from using tag and todo folders in KMail is that searching is too slow. Well, I don't actually mind the spped too much, but the fact that the UI is blocked, especially for large search folders. I wonder if this is worth looking at or if we should wait for Akonadi.


/trunk/KDE/kdepim/kmail/rulewidgethandlermanager.cpp
<http://reviewboard.kde.org/r/796/#comment820>

    Please use names starting with lower case for  variables. Same for TagFunctions.



/trunk/KDE/kdepim/kmail/rulewidgethandlermanager.cpp
<http://reviewboard.kde.org/r/796/#comment819>

    change "" to QString() (or Krazy will complain)


- Thomas


On 2009-06-11 07:38:16, Jonathan Armond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/796/
> -----------------------------------------------------------
> 
> (Updated 2009-06-11 07:38:16)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Allow searching messages by tag, and also using tags as a filter criteria. This allows the use of search folders.
> 
> 
> This addresses bugs 136555 and 182279.
>     https://bugs.kde.org/show_bug.cgi?id=136555
>     https://bugs.kde.org/show_bug.cgi?id=182279
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmsearchpattern.h 980307 
>   /trunk/KDE/kdepim/kmail/kmsearchpattern.cpp 980307 
>   /trunk/KDE/kdepim/kmail/kmsearchpatternedit.h 980307 
>   /trunk/KDE/kdepim/kmail/kmsearchpatternedit.cpp 980307 
>   /trunk/KDE/kdepim/kmail/rulewidgethandlermanager.cpp 980307 
>   /trunk/KDE/kdepim/kmail/searchjob.cpp 980307 
> 
> Diff: http://reviewboard.kde.org/r/796/diff
> 
> 
> Testing
> -------
> 
> Can search messages by tag. Manually applied filters by tag works.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/