[Kde-pim] Review Request: Allow searching by tag

[Jonathan Armond]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/796/
-----------------------------------------------------------

(Updated 2009-06-11 07:38:16.830433)


Review request for KDE PIM.


Changes
-------

Derived RuleWidgetHandler for tags using KComboBox (except for regexps). Tag searches are stored as strings, so deleting tag doesn't affect filter. However, reloading the message list strips out deleted tags anyway. 


Summary
-------

Allow searching messages by tag, and also using tags as a filter criteria. This allows the use of search folders.


This addresses bugs 136555 and 182279.
    https://bugs.kde.org/show_bug.cgi?id=136555
    https://bugs.kde.org/show_bug.cgi?id=182279


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/kmsearchpattern.h 980307 
  /trunk/KDE/kdepim/kmail/kmsearchpattern.cpp 980307 
  /trunk/KDE/kdepim/kmail/kmsearchpatternedit.h 980307 
  /trunk/KDE/kdepim/kmail/kmsearchpatternedit.cpp 980307 
  /trunk/KDE/kdepim/kmail/rulewidgethandlermanager.cpp 980307 
  /trunk/KDE/kdepim/kmail/searchjob.cpp 980307 

Diff: http://reviewboard.kde.org/r/796/diff


Testing
-------

Can search messages by tag. Manually applied filters by tag works.


Thanks,

Jonathan

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/