[Kde-pim] JJ: Rename Account Wizard Cancel Button

[Joe Burns]

Hey Thomas,

On Wednesday 10 June 2009 12:19:45 pm Thomas McGuire wrote:
> The patch itself is fine, except some minor style issues (see below)
>
> KDE is currently in string freeze until KDE 4.3 is released, see
> http://techbase.kde.org/Schedules/KDE4/4.3_Release_Schedule
>
> Because of the string freeze, committing your patch needs to wait until the
> freeze is lifted.
>
> Reviewboard was down for scheduled maintenance, it should be up again. Can
> you please post the patch there so it doesn't get lost until the freeze is
> over?

Yep I'll go ahead and post the updated patch on reviewboard.

>
> Now the minor style issues:
>
> Use #include <KPushButton> instead of #include <kpushbutton.h>, that is the
> new style of doing includes.
> Also, we in KDEPIM have a crazy style regarding whitespace: We add a space
> on the inside of operators, so it should become:
>
> button( KDialog::Cancel )->setText( i18n( "Create an Account Later" ) );
>
> Thanks for the patch!

I plan on tackling some of the other issues listed on that JJ page. I'll be on 
#kontact in the next few days because I'm sure I'll have questions. My nick is 
josebur btw.

Thanks for the review.

Joe
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/