[Kde-pim] Review Request: zoom support for all tabs in akregator

[Frank Osterfeld]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1104/#review1798
-----------------------------------------------------------


Please use qobject_cast instead of isKHTMLPart() + c-style cast.

Looks good otherwise - I think it can go into 4.3.1. (too short notice for 4.3.0)

- Frank


On 2009-07-23 19:30:14, Alexander Elbs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1104/
> -----------------------------------------------------------
> 
> (Updated 2009-07-23 19:30:14)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> - Move zoom action into tabwidget and send zoom in/out signals to all tabs. I didn't find out how to tell a readonly part to zoom, so I casted it to khtmlpart (if the part is khtml). Could be extended for other types.
> - Tabs load/save zoom factor
> - Add zoom in/out entries in popup menu for tabs.
> - Remove dead code (scroll up/down)
> - Fix typo in signal name (UserActionTakingPlace)
> 
> 
> Diffs
> -----
> 
>   branches/KDE/4.3/kdepim/akregator/src/actionmanagerimpl.cpp 1001603 
>   branches/KDE/4.3/kdepim/akregator/src/articleviewer.h 1001603 
>   branches/KDE/4.3/kdepim/akregator/src/articleviewer.cpp 1001603 
>   branches/KDE/4.3/kdepim/akregator/src/browserframe.h 1001603 
>   branches/KDE/4.3/kdepim/akregator/src/browserframe.cpp 1001603 
>   branches/KDE/4.3/kdepim/akregator/src/mainwidget.cpp 1001603 
>   branches/KDE/4.3/kdepim/akregator/src/tabwidget.h 1001603 
>   branches/KDE/4.3/kdepim/akregator/src/tabwidget.cpp 1001603 
> 
> Diff: http://reviewboard.kde.org/r/1104/diff
> 
> 
> Testing
> -------
> 
> - opened tabs
> - ctrl-+, ctrl-- zoom in/out in current tab
> - same for popup menu and menu.
> - opening/closing tabs: still current tab is zoomed.
> - closing akregator, opening akreagtor: zoom factor for all tabs except articleviewer is restored
> 
> 
> Thanks,
> 
> Alexander
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/