[Kde-pim] Review Request: zoom support for all tabs in akregator

Alexander Elbs alex at segv.de
Thu Jul 23 20:30:14 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1104/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

- Move zoom action into tabwidget and send zoom in/out signals to all tabs. I didn't find out how to tell a readonly part to zoom, so I casted it to khtmlpart (if the part is khtml). Could be extended for other types.
- Tabs load/save zoom factor
- Add zoom in/out entries in popup menu for tabs.
- Remove dead code (scroll up/down)
- Fix typo in signal name (UserActionTakingPlace)


Diffs
-----

  branches/KDE/4.3/kdepim/akregator/src/actionmanagerimpl.cpp 1001603 
  branches/KDE/4.3/kdepim/akregator/src/articleviewer.h 1001603 
  branches/KDE/4.3/kdepim/akregator/src/articleviewer.cpp 1001603 
  branches/KDE/4.3/kdepim/akregator/src/browserframe.h 1001603 
  branches/KDE/4.3/kdepim/akregator/src/browserframe.cpp 1001603 
  branches/KDE/4.3/kdepim/akregator/src/mainwidget.cpp 1001603 
  branches/KDE/4.3/kdepim/akregator/src/tabwidget.h 1001603 
  branches/KDE/4.3/kdepim/akregator/src/tabwidget.cpp 1001603 

Diff: http://reviewboard.kde.org/r/1104/diff


Testing
-------

- opened tabs
- ctrl-+, ctrl-- zoom in/out in current tab
- same for popup menu and menu.
- opening/closing tabs: still current tab is zoomed.
- closing akregator, opening akreagtor: zoom factor for all tabs except articleviewer is restored


Thanks,

Alexander

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list