[Kde-pim] Review Request: jj: Move aggregation, theme and sorting options to the menubar

[James Bendig]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1154/
-----------------------------------------------------------

(Updated 2009-07-29 15:30:17.094160)


Review request for KDE PIM.


Changes
-------

Removed sub-menu duplication.
Changed menu names to be more consistent with existing menu names.

The titles in View->Message List->Sorting, "Message Sort Order" and "Message Sort Direction", seem redundant and inconsistent by being prefixed with "Message". Shall I change them as well?


Summary
-------

I removed the sort, aggregation, and theme buttons and added their choices to "View->Message List" and the Message List header context menu.

Are equivalent settings in the configure dialog still requested? I saw a few existing settings were recently removed from SVN trunk.


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/kmail_part.rc 1003677 
  /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 1003677 
  /trunk/KDE/kdepim/kmail/kmmainwin.rc 1003677 
  /trunk/KDE/kdepim/kmail/messagelistview/core/view.h 1003677 
  /trunk/KDE/kdepim/kmail/messagelistview/core/view.cpp 1003677 
  /trunk/KDE/kdepim/kmail/messagelistview/core/widgetbase.h 1003677 
  /trunk/KDE/kdepim/kmail/messagelistview/core/widgetbase.cpp 1003677 
  /trunk/KDE/kdepim/kmail/messagelistview/pane.h 1003677 
  /trunk/KDE/kdepim/kmail/messagelistview/pane.cpp 1003677 

Diff: http://reviewboard.kde.org/r/1154/diff


Testing
-------


Thanks,

James

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/