[Kde-pim] Review Request: jj: Move aggregation, theme and sorting options to the menubar

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1154/#review1830
-----------------------------------------------------------


Thanks for the patch, adding that to the context menu of the header was a good idea.
Please remove the code duplication I mentioned below, than I can commit this (or you can, if you have a SVN account). At the same time, the patch that changes the status filter to a combobox again can be comitted

Yes, I still want the _global_ sort order, aggregation and theme in the config dialog.
Currently, the global/per-folder settings are not very intuitive, it is just a single, badly-labled checkbox.
What should happen if the checkbox is unchecked, should the global settings be changed to those of the current folder of should the current folder's settings be changed to the global ones? Similar problem when checking that checkbox. Because of this, I think a single checkbox is not the best way, but I don't have any good UI ideas either.
This all of course is not relevant to the current review request, just wanted to point out the problems with the current per-folder/global settings.


/trunk/KDE/kdepim/kmail/messagelistview/core/view.cpp
<http://reviewboard.kde.org/r/1154/#comment1192>

    This is duplicated code, it would be nice to have the setup of those 3 sub-menus shared somewhere.



/trunk/KDE/kdepim/kmail/messagelistview/pane.cpp
<http://reviewboard.kde.org/r/1154/#comment1196>

    I think this should just be "Sort Order", without the "Change".
    This would be more consistent with the other entries in the View menu, like "View->Headers" (it is not View->Change Headers)
    
    Same for the other 2 submenus


- Thomas


On 2009-07-29 01:22:09, James Bendig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1154/
> -----------------------------------------------------------
> 
> (Updated 2009-07-29 01:22:09)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> I removed the sort, aggregation, and theme buttons and added their choices to "View->Message List" and the Message List header context menu.
> 
> Are equivalent settings in the configure dialog still requested? I saw a few existing settings were recently removed from SVN trunk.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmail_part.rc 1003677 
>   /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 1003677 
>   /trunk/KDE/kdepim/kmail/kmmainwin.rc 1003677 
>   /trunk/KDE/kdepim/kmail/messagelistview/core/view.cpp 1003677 
>   /trunk/KDE/kdepim/kmail/messagelistview/core/widgetbase.h 1003677 
>   /trunk/KDE/kdepim/kmail/messagelistview/core/widgetbase.cpp 1003677 
>   /trunk/KDE/kdepim/kmail/messagelistview/pane.h 1003677 
>   /trunk/KDE/kdepim/kmail/messagelistview/pane.cpp 1003677 
> 
> Diff: http://reviewboard.kde.org/r/1154/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> James
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/