[Kde-pim] Review Request: Fix KMail crashy krazy2 issues

[Ingo Klöcker]

> On 2009-07-08 06:49:59, Thomas McGuire wrote:
> >
> 
> Michael Leupold wrote:
>     After the discussion on k-c-d it seems we'll be using QScopedPointer for KDE 4.4. What about this patch? Should we fix this using QPointer and merge this into the 4.3 branch to avoid possible crashes inside kontact, fix it using a private copy of KAutoPointer or leave it till we get the Qt class?

QScopedPointer will not magically fix this problem because QScopedPointer is unaware of QObject's feature to eat its children on deletion. This means that QObjects which have a parent should never be used with QScopedPointer because this will very likely lead to double deletion problems.

So, until the problem is solved as we discussed on k-c-d (Lubos and Thiago suggested that an application showing a modal dialog should refuse to quit), it might be a good idea to use AutoQPointer for the time being.


- Ingo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/950/#review1497
-----------------------------------------------------------


On 2009-07-08 07:12:27, Michael Leupold wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/950/
> -----------------------------------------------------------
> 
> (Updated 2009-07-08 07:12:27)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This is the start of my work on some of the KMail krazy2 issues fixing the crashy dialog-on-stack issue.
> 
> It's not really intended for review as I haven't done any tests yet (it compiles and *might* work). Still I thought it might be a good idea to upload so you know that I'm on it and we can avoid redundant work.
> 
> ... please ignore the kaddressbook part. I'm not really sure where that comes from and it's definitely not part of the patch :)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/accountdialog.cpp 992911 
>   /trunk/KDE/kdepim/kmail/accountwizard.cpp 992911 
>   /trunk/KDE/kdepim/kmail/configuredialog.cpp 992911 
>   /trunk/KDE/kdepim/kmail/editorwatcher.cpp 992911 
>   /trunk/KDE/kdepim/kmail/favoritefolderview.cpp 992911 
>   /trunk/KDE/kdepim/kmail/filterimporterexporter.cpp 992911 
>   /trunk/KDE/kdepim/kmail/filterlogdlg.cpp 992911 
>   /trunk/KDE/kdepim/kmail/folderdialogacltab.cpp 992911 
>   /trunk/KDE/kdepim/kmail/folderrequester.cpp 992911 
>   /trunk/KDE/kdepim/kmail/imapaccountbase.cpp 992911 
>   /trunk/KDE/kdepim/kmail/kmcommands.cpp 992911 
>   /trunk/KDE/kdepim/kmail/kmcomposewin.cpp 992911 
>   /trunk/KDE/kdepim/kmail/kmfoldercachedimap.cpp 992911 
>   /trunk/KDE/kdepim/kmail/kmlineeditspell.cpp 992911 
>   /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 992911 
>   /trunk/KDE/kdepim/kmail/messagelistview/core/themeeditor.cpp 992911 
>   /trunk/KDE/kdepim/kmail/objecttreeparser.cpp 992911 
>   /trunk/KDE/kdepim/kmail/recipientseditor.cpp 992911 
>   /trunk/KDE/kdepim/kmail/redirectdialog.cpp 992911 
>   /trunk/KDE/kdepim/kmail/snippetwidget.cpp 992911 
> 
> Diff: http://reviewboard.kde.org/r/950/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/