[Kde-pim] Review Request: Fix KMail crashy krazy2 issues

[Michael Leupold]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/950/
-----------------------------------------------------------

(Updated 2009-07-21 12:55:33.032512)


Review request for KDE PIM.


Changes
-------

Use a private copy of kdepim/kalarm/lib/autoqpointer.h to fix crashy issues.

Note: autoqpointer.h is not included in this patch as my script to extract reviewboard diffs from git messes up and interprets the copy as a change in the original file. So here are my changes to the private copy kdepim/kmail/autoqpointer.h:
- Removed line "Program:  kalarm" from header
- Added line "*  This is a (mostly) verbatim, private copy of kdepim/kalarm/lib/autoqpointer.h" to header
- reformatted using KMail style (no tabs, 2-space indent)


Summary
-------

This is the start of my work on some of the KMail krazy2 issues fixing the crashy dialog-on-stack issue.

It's not really intended for review as I haven't done any tests yet (it compiles and *might* work). Still I thought it might be a good idea to upload so you know that I'm on it and we can avoid redundant work.

... please ignore the kaddressbook part. I'm not really sure where that comes from and it's definitely not part of the patch :)


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/accountdialog.cpp 1000470 
  /trunk/KDE/kdepim/kmail/accountwizard.h 1000470 
  /trunk/KDE/kdepim/kmail/accountwizard.cpp 1000470 
  /trunk/KDE/kdepim/kmail/configuredialog.cpp 1000470 
  /trunk/KDE/kdepim/kmail/editorwatcher.cpp 1000470 
  /trunk/KDE/kdepim/kmail/favoritefolderview.cpp 1000470 
  /trunk/KDE/kdepim/kmail/filterimporterexporter.cpp 1000470 
  /trunk/KDE/kdepim/kmail/filterlogdlg.cpp 1000470 
  /trunk/KDE/kdepim/kmail/folderdialogacltab.cpp 1000470 
  /trunk/KDE/kdepim/kmail/folderrequester.cpp 1000470 
  /trunk/KDE/kdepim/kmail/imapaccountbase.cpp 1000470 
  /trunk/KDE/kdepim/kmail/kmcommands.cpp 1000470 
  /trunk/KDE/kdepim/kmail/kmcomposewin.cpp 1000470 
  /trunk/KDE/kdepim/kmail/kmfoldercachedimap.cpp 1000470 
  /trunk/KDE/kdepim/kmail/kmlineeditspell.cpp 1000470 
  /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 1000470 
  /trunk/KDE/kdepim/kmail/messagelistview/core/themeeditor.cpp 1000470 
  /trunk/KDE/kdepim/kmail/objecttreeparser.cpp 1000470 
  /trunk/KDE/kdepim/kmail/recipientseditor.cpp 1000470 
  /trunk/KDE/kdepim/kmail/redirectdialog.cpp 1000470 
  /trunk/KDE/kdepim/kmail/snippetwidget.cpp 1000470 

Diff: http://reviewboard.kde.org/r/950/diff


Testing
-------


Thanks,

Michael

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/