[Kde-pim] Review Request: Fix zoom in akregator

[Alexander Elbs]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/981/
-----------------------------------------------------------

(Updated 2009-07-11 19:38:21.104339)


Review request for KDE PIM.


Changes
-------

- changed decFontSizes and incFontSizes to dec_font_sizes/inc_font_sizes
- Use QKeySequence::ZoomIn / ZoomOut

@Frank: the strings i18n("&Increase Font Sizes") and i18n("&Decrease Font Sizes") have been in there. I just moved them around.
I think renaming actions is dangerous, because akregator_part.rc is copied to ~/.kde/ and won't be updated by akregator. So several menu points would vanish. However renaming dec/incFontSizes is harmless, because they haven't been properly used so far. But if a copy of akregator_part.rc is in ~/.kde/ the new menu points in "View" for font size changes will not appear (took me a while to figure out). I don't know how this upgrade is/should be handled.

I don't have a svn account, so someone needs to commit these changes to trunk and/or 4.3.


Summary
-------

This patch enables ctrl-+ and ctrl-- again to enlarge/shrink the font of the
articleviewer (font != zoom). These two actions are also added to the "View"
menu.
Additionally actions for print (ctrl-p) and copy (ctrl-c) now also work again
with shortcuts and are configurable in the shortcut configuration menu.

This should fix bug 163391


This addresses bug 163391.
    https://bugs.kde.org/show_bug.cgi?id=163391


Diffs (updated)
-----

  trunk/KDE/kdepim/akregator/src/pageviewer.cpp 988800 
  trunk/KDE/kdepim/akregator/src/pageviewer.rc 988800 
  trunk/KDE/kdepim/akregator/src/articleviewer.rc 988800 
  trunk/KDE/kdepim/akregator/src/articleviewer.cpp 988800 
  trunk/KDE/kdepim/akregator/src/akregator_part.rc 988800 
  trunk/KDE/kdepim/akregator/src/actionmanagerimpl.cpp 988800 

Diff: http://reviewboard.kde.org/r/981/diff


Testing
-------

- Enlarge/shrink font show up in Menu "View"
- Enlarge/shrink font are in pop menu in khtml part
- Enlarge/shrink font can be configured in short cut menu
- Print and Copy can be configured in short cut menu
- Ctrl-+, Ctrl--, Ctrl-p, ctrl-c do have an effect


Thanks,

Alexander

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/