[Kde-pim] Review Request: Fix zoom in akregator

Frank Osterfeld frank.osterfeld at gmail.com
Sat Jul 11 13:18:08 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/981/#review1546
-----------------------------------------------------------

Ship it!


Looks good, please commit to trunk. The patch includes string changes, thus no 4.3 branch (some of the fixes not requiring string changes could be backported though)
decFontSizes etc. should follow the existing action naming style, i.e. dec_font_size etc.

- Frank


On 2009-07-10 02:00:56, Alexander Elbs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/981/
> -----------------------------------------------------------
> 
> (Updated 2009-07-10 02:00:56)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch enables ctrl-+ and ctrl-- again to enlarge/shrink the font of the
> articleviewer (font != zoom). These two actions are also added to the "View"
> menu.
> Additionally actions for print (ctrl-p) and copy (ctrl-c) now also work again
> with shortcuts and are configurable in the shortcut configuration menu.
> 
> This should fix bug 163391
> 
> 
> This addresses bug 163391.
>     https://bugs.kde.org/show_bug.cgi?id=163391
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/akregator/src/actionmanagerimpl.cpp 988800 
>   trunk/KDE/kdepim/akregator/src/akregator_part.rc 988800 
>   trunk/KDE/kdepim/akregator/src/articleviewer.cpp 988800 
> 
> Diff: http://reviewboard.kde.org/r/981/diff
> 
> 
> Testing
> -------
> 
> - Enlarge/shrink font show up in Menu "View"
> - Enlarge/shrink font are in pop menu in khtml part
> - Enlarge/shrink font can be configured in short cut menu
> - Print and Copy can be configured in short cut menu
> - Ctrl-+, Ctrl--, Ctrl-p, ctrl-c do have an effect
> 
> 
> Thanks,
> 
> Alexander
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list