[Kde-pim] Review Request: Apply template when switching identity in message composer

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/833/#review1733
-----------------------------------------------------------

Ship it!


Thanks for fixing the remaining problems, please commit!

I didn't test it again, but I assume it works. And even if there are any bugs left, those can be fixed in trunk.

Thanks for all the work :)

- Thomas


On 2009-07-23 18:04:30, Jonathan Armond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/833/
> -----------------------------------------------------------
> 
> (Updated 2009-07-23 18:04:30)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Apply new template when switching identity in the message composer, as long the message has not been modified. NB: changing identity no longer marks message as modified.
> 
> Apply template to Forward As Attachment messages.
> 
> First attempt at fixing bug 143199.
> 
> 
> This addresses bugs 143199, 179754 and 186843.
>     https://bugs.kde.org/show_bug.cgi?id=143199
>     https://bugs.kde.org/show_bug.cgi?id=179754
>     https://bugs.kde.org/show_bug.cgi?id=186843
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/composer.h 1001553 
>   /trunk/KDE/kdepim/kmail/kmcommands.cpp 1001553 
>   /trunk/KDE/kdepim/kmail/kmcomposewin.h 1001553 
>   /trunk/KDE/kdepim/kmail/kmcomposewin.cpp 1001553 
>   /trunk/KDE/kdepim/kmail/kmkernel.cpp 1001553 
>   /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 1001553 
>   /trunk/KDE/kdepim/kmail/templateparser.h 1001553 
>   /trunk/KDE/kdepim/kmail/templateparser.cpp 1001553 
> 
> Diff: http://reviewboard.kde.org/r/833/diff
> 
> 
> Testing
> -------
> 
> Template properly parsed for new, reply, reply all and forward. Switches between custom, global and no templates properly. Doesn't switch after modifying message.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/