[Kde-pim] Review Request: JJ: Unify options to enable or disable the tooltips in the folder and message list

[James Bendig]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1105/#review1727
-----------------------------------------------------------



/trunk/KDE/kdepim/kmail/kmmainwidget.cpp
<http://reviewboard.kde.org/r/1105/#comment1120>

    Why was config being written immediately before reading? This was causing FolderView to write over the tooltip changes immediately made by ConfigureDialog beforehand. I did not notice any other side effects after removal.



/trunk/KDE/kdepim/kmail/messagelistview/core/manager.cpp
<http://reviewboard.kde.org/r/1105/#comment1121>

    Added to stay consistent with loadGlobalConfiguration above.


- James


On 2009-07-24 16:27:27, James Bendig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1105/
> -----------------------------------------------------------
> 
> (Updated 2009-07-24 16:27:27)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This is a fix to unify Message List and Folder List tooltips so both can be changed in the same places.
> 
> Added "Folder Tooltips" radio group to Configure->Appearance->Layout.
> Added "Display Tooltips" checkbox to Message List header context menu.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/configuredialog.cpp 1001564 
>   /trunk/KDE/kdepim/kmail/configuredialog_p.h 1001564 
>   /trunk/KDE/kdepim/kmail/folderview.cpp 1001564 
>   /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 1001564 
>   /trunk/KDE/kdepim/kmail/messagelistview/core/manager.h 1001564 
>   /trunk/KDE/kdepim/kmail/messagelistview/core/manager.cpp 1001564 
>   /trunk/KDE/kdepim/kmail/messagelistview/core/view.cpp 1001564 
> 
> Diff: http://reviewboard.kde.org/r/1105/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> James
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/