[Kde-pim] Review Request: JJ: Unify options to enable or disable the tooltips in the folder and message list

[Thomas McGuire]

> On 2009-07-24 16:47:36, James Bendig wrote:
> > /trunk/KDE/kdepim/kmail/kmmainwidget.cpp, line 574
> > <http://reviewboard.kde.org/r/1105/diff/1/?file=8918#file8918line574>
> >
> >     Why was config being written immediately before reading? This was causing FolderView to write over the tooltip changes immediately made by ConfigureDialog beforehand. I did not notice any other side effects after removal.

Ok, I see.
I have the nagging feeling that the writeConfig() call was there for a reason, but we'll see if that will cause any regressions.
SVN annotate did not turn up anything useful (I'm so glad when we'll have git and don't break history by merging stuff all the time!)


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1105/#review1727
-----------------------------------------------------------


On 2009-07-24 16:27:27, James Bendig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1105/
> -----------------------------------------------------------
> 
> (Updated 2009-07-24 16:27:27)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This is a fix to unify Message List and Folder List tooltips so both can be changed in the same places.
> 
> Added "Folder Tooltips" radio group to Configure->Appearance->Layout.
> Added "Display Tooltips" checkbox to Message List header context menu.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/configuredialog.cpp 1001564 
>   /trunk/KDE/kdepim/kmail/configuredialog_p.h 1001564 
>   /trunk/KDE/kdepim/kmail/folderview.cpp 1001564 
>   /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 1001564 
>   /trunk/KDE/kdepim/kmail/messagelistview/core/manager.h 1001564 
>   /trunk/KDE/kdepim/kmail/messagelistview/core/manager.cpp 1001564 
>   /trunk/KDE/kdepim/kmail/messagelistview/core/view.cpp 1001564 
> 
> Diff: http://reviewboard.kde.org/r/1105/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> James
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/