[Kde-pim] Review Request: Change Entity::Id from qint64 to qlonglong

Sascha Peilicke sasch.pe at gmx.de
Thu Jul 23 18:13:12 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1102/
-----------------------------------------------------------

(Updated 2009-07-23 17:13:12.416842)


Review request for KDE PIM, Kevin Krammer and Volker Krause.


Summary
-------

I recommend changing the type of Akonadi::Entity::Id from qint64 to qlonglong. Both types are identical but the latter idom is used across Qt's API. For example when you have to convert an Id from/to a QString/QByteArray you would use the method toLongLong(). There is nothing like toUint64(). So this small patch should reduce some confusion (I had to look up the type in the code before I was sure how to convert it correctly).


Diffs
-----

  trunk/KDE/kdepimlibs/akonadi/entity.h 1000610 

Diff: http://reviewboard.kde.org/r/1102/diff


Testing
-------


Thanks,

Sascha

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list