[Kde-pim] [Patch] Change the way Akregator handles new articles

Armin Berres trigger at space-based.de
Fri Jan 9 00:15:49 GMT 2009


Some notes after the first feedback:

> Index: src/articlelistview.cpp
> ===================================================================
> --- src/articlelistview.cpp     (revision 907883)
> +++ src/articlelistview.cpp     (working copy)
> @@ -49,6 +49,9 @@
> 
>  #include <cassert>

> +#include <boost/archive/polymorphic_xml_oarchive.hpp>
> +#include <boost/archive/polymorphic_text_iarchive.hpp>

Included by accident. Should be removed.


On Fri, 09 Jan 09 00:00, Armin Berres wrote:  
> Index: akregator/src/folder.h
> ===================================================================
> --- akregator/src/folder.h	(revision 907883)
> +++ akregator/src/folder.h	(working copy)
> @@ -68,10 +68,17 @@
>          @return number of unread articles */
>          int unread() const;
>  
> +        /** returns the number of new articles in all children
> +        @return number of new articles */
> +        int newCount() const;
> +
>          /** returns the number of articles in all children
>          @return number of articles */
>          int totalCount() const;
>  
> +        /** does nothing. otherwise all new articles are marked immediately as unread, when one selects the first time a feed/folder after starting.  */
> +        void markNewAsUnread() {};

The comment should contain a FIXME, wasn't intended to stay there
forever.
The real problem is, that Akregator::SelectionController::selectedSubscriptionChanged(...) 
is called the first time the user selects a folder/feed the former
selected node seems to be some kind of invisible parent. Because
of this all and every new message is marked as unread.
My Qt knowledge left me here and I hadn't time yet to investigate
further...

/Armin
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list