[Kde-pim] Review Request: Improve behavior of Kolab's KCal resource

[Kevin Krammer]

> On 2009-02-07 11:45:58, Volker Krause wrote:
> > Looks ok to me, no idea about the error case either.

It is mainly causing problems for the KCal bridge resource and Kolab is one of the plugins which are hard to bridge anyway.
I discovered this deviation mainly by accident since I was testing full migration again.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/39/#review38
-----------------------------------------------------------


On 2009-02-07 10:14:02, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/39/
> -----------------------------------------------------------
> 
> (Updated 2009-02-07 10:14:02)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> During an Akonadi migration test I discovered that the bridge for the Kolab KCal resource seemed to fail to finish its loading stage.
> The one for KABC loaded just fine, and KMail was successfully launched.
> 
> Turns out the resource "forgets" to emit the resourceLoaded() signal.
> It might also not call loadError() if there is one.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kresources/kolab/kcal/resourcekolab.cpp 922878 
> 
> Diff: http://reviewboard.kde.org/r/39/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/