[Kde-pim] Review Request: use MimeTypeChecker in CollectionFilterProxyModel

Tom Albers tomalbers at kde.nl
Sun Feb 15 14:22:09 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/89/#review111
-----------------------------------------------------------


Looks ok to me

- Tom


On 2009-02-15 05:54:48, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/89/
> -----------------------------------------------------------
> 
> (Updated 2009-02-15 05:54:48)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This unifies the handling of a match. Previously a match for same MIME string had a different code block than KMimeType based match.
> My guess is that this second path didn't get executed because all our MIMEs so far are direct string matches.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/akonadi/collectionfilterproxymodel.cpp 926448 
> 
> Diff: http://reviewboard.kde.org/r/89/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list