[Kde-pim] Review Request: Fix base implementation of ResourceCalendar::doSave(bool, Incidence*)

Kevin Krammer kevin.krammer at gmx.at
Sun Feb 15 20:37:40 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/95/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

Current implementation is an infinite recursion (method calling itself) and the API docs say it calls doSave(bool).

Actually the override in ResourceCached is implemented properly and fortunately this is used as the base class by most other implementations.


Diffs
-----

  /trunk/KDE/kdepimlibs/kcal/resourcecalendar.cpp 926589 

Diff: http://reviewboard.kde.org/r/95/diff


Testing
-------


Thanks,

Kevin

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list