[Kde-pim] Review Request: KCal client bridge: unify processing of "save all" and "save single incidence"

Volker Krause vkrause at kde.org
Sun Feb 15 22:20:52 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/94/#review124
-----------------------------------------------------------

Ship it!


Looks ok to me.

- Volker


On 2009-02-15 13:04:14, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/94/
> -----------------------------------------------------------
> 
> (Updated 2009-02-15 13:04:14)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The "save all" method of deciding which job to use was using incidence change tracking, but the "save single incidence" did it based on whether an incidence mapped to an existing item.
> 
> This makes the "single incidence" case use the same method.
> Currently just an improvment and code reduction, but necessary once the CalendarResources fix Sergio Martins is working on is committed.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kresources/akonadi/kcal/resourceakonadi.h 926602 
>   /trunk/KDE/kdepim/kresources/akonadi/kcal/resourceakonadi.cpp 926602 
> 
> Diff: http://reviewboard.kde.org/r/94/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list