[Kde-pim] Review Request: Change kjots buildsystem to allow building it without kdepim

Allen Winter winter at kde.org
Thu Feb 5 23:09:50 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/12/#review31
-----------------------------------------------------------

Ship it!


So everything stays the same with the build process unless someone comments out KJOTSKONTACTPLUGIN definition in the top-level CMakeLists.txt?  I guess that's ok.  A little ugly, but not horrible.

- Allen


On 2009-02-05 11:45:47, Stephen Kelly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/12/
> -----------------------------------------------------------
> 
> (Updated 2009-02-05 11:45:47)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Proposed changes to KJots build system. Allow building kjots without kdepim to make it easier for new contributors by using cmake with -DNOKONTACTPLUGIN.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/CMakeLists.txt 921831 
>   trunk/KDE/kdepim/kjots/CMakeLists.txt 921831 
>   trunk/KDE/kdepim/kjots/aboutdata.cpp 921831 
>   trunk/KDE/kdepim/kjots/main.cpp 921831 
> 
> Diff: http://reviewboard.kde.org/r/12/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stephen
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list