[Kde-pim] Review Request: Addition of "Maintenance" tab to the folder properties dialogue

[Jonathan Marten]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/48/
-----------------------------------------------------------

(Updated 2009-02-17 03:36:33.578640)


Review request for KDE PIM.


Changes
-------

Updated patch in accordance with review comments...

Moved the 'mDlg' member into the base class, as suggested.

Added two functions to encapsulate the contents/storage type->string decoding.

Removed the rebuild/troubleshoot options from the menu bar "Folder" menu also.

"Maintenance" tab is now last, after the IMAP tabs if present.

The "Compact Now" button is only shown for mbox folders.

Still can't seem to find the equivalent to convertSizeWithBytes(), not even at the page
referenced.

Using folder->storage()->folderSize() and signal folderSizeChanged to display the folder size.

The hooks for assimilating more tabs into the properties dialogue (mShortcutTab etc and
KMFolderDialog:;setPage() are still present.  I'd still like to have the option of combining
these tabs one day, even if it is hidden behind an "Expert Mode" profile option not enabled
by default.


Summary
-------

Addition of "Maintenance" tab to the folder properties dialogue.  This displays some information about the folder and index files and the compaction status.  The actions "Rebuild Index" and "Rebuild IMAP Cache" have been moved from the folder popup menu to here.

Added function enableCompaction() to folderstorage.{cpp,h} to allow the folder to be compacted (after user confirmation) if the "compaction unsafe" flag has been set.  There was previously no way to do this apart from editing the kmailrc configuration file.

Removed slotAssignShortcut() from folderview.{cpp,h} - the corresponding action from the main window is used instead.

Moved the "mark_all_as_read" action back to the top of the folder popup menu, as suggested by aseigo.


This addresses bug 115611.
    https://bugs.kde.org/show_bug.cgi?id=115611


Diffs (updated)
-----

  trunk/KDE/kdepim/kmail/folderdialogacltab.h 927301 
  trunk/KDE/kdepim/kmail/folderdialogacltab.cpp 927301 
  trunk/KDE/kdepim/kmail/folderdialogquotatab.h 927301 
  trunk/KDE/kdepim/kmail/folderdialogquotatab.cpp 927301 
  trunk/KDE/kdepim/kmail/folderstorage.h 927301 
  trunk/KDE/kdepim/kmail/folderstorage.cpp 927301 
  trunk/KDE/kdepim/kmail/folderview.h 927301 
  trunk/KDE/kdepim/kmail/folderview.cpp 927301 
  trunk/KDE/kdepim/kmail/identitydialog.cpp 927301 
  trunk/KDE/kdepim/kmail/kmail_part.rc 927301 
  trunk/KDE/kdepim/kmail/kmfolderdialog.h 927301 
  trunk/KDE/kdepim/kmail/kmfolderdialog.cpp 927301 
  trunk/KDE/kdepim/kmail/kmmainwidget.h 927301 
  trunk/KDE/kdepim/kmail/kmmainwidget.cpp 927301 
  trunk/KDE/kdepim/kmail/kmmainwin.rc 927301 

Diff: http://reviewboard.kde.org/r/48/diff


Testing
-------

Built KMail from trunk with these patches, checked operation of all functions.


Thanks,

Jonathan

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/