[Kde-pim] Review Request: Addition of "Maintenance" tab to the folder properties dialogue

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/48/#review153
-----------------------------------------------------------

Ship it!


Looks almost perfect, expect the minor comments I added below.
Fix those and then commit directly, no need for an additional review I think.
BTW, no idea about the KIO::convertSize() thing, i thought those other KIO methods would be the same, but I might have been wrong.

Thanks for this nice patch.


trunk/KDE/kdepim/kmail/kmfolderdialog.h
<http://reviewboard.kde.org/r/48/#comment79>

    Prefix this variables with 'm' as well.



trunk/KDE/kdepim/kmail/kmfolderdialog.cpp
<http://reviewboard.kde.org/r/48/#comment80>

    This looks wrong, it makes no sense to hide the "compat" button but show a compaction status. I think fillContextMenuFolderServiceRelatedActions() should be fixed as well, to only show that action for MBox folders.



trunk/KDE/kdepim/kmail/kmfolderdialog.cpp
<http://reviewboard.kde.org/r/48/#comment81>

    KPushButton, not QPushbutton. Also in other places.


- Thomas


On 2009-02-17 03:36:33, Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/48/
> -----------------------------------------------------------
> 
> (Updated 2009-02-17 03:36:33)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Addition of "Maintenance" tab to the folder properties dialogue.  This displays some information about the folder and index files and the compaction status.  The actions "Rebuild Index" and "Rebuild IMAP Cache" have been moved from the folder popup menu to here.
> 
> Added function enableCompaction() to folderstorage.{cpp,h} to allow the folder to be compacted (after user confirmation) if the "compaction unsafe" flag has been set.  There was previously no way to do this apart from editing the kmailrc configuration file.
> 
> Removed slotAssignShortcut() from folderview.{cpp,h} - the corresponding action from the main window is used instead.
> 
> Moved the "mark_all_as_read" action back to the top of the folder popup menu, as suggested by aseigo.
> 
> 
> This addresses bug 115611.
>     https://bugs.kde.org/show_bug.cgi?id=115611
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kmail/folderdialogacltab.h 927301 
>   trunk/KDE/kdepim/kmail/folderdialogacltab.cpp 927301 
>   trunk/KDE/kdepim/kmail/folderdialogquotatab.h 927301 
>   trunk/KDE/kdepim/kmail/folderdialogquotatab.cpp 927301 
>   trunk/KDE/kdepim/kmail/folderstorage.h 927301 
>   trunk/KDE/kdepim/kmail/folderstorage.cpp 927301 
>   trunk/KDE/kdepim/kmail/folderview.h 927301 
>   trunk/KDE/kdepim/kmail/folderview.cpp 927301 
>   trunk/KDE/kdepim/kmail/identitydialog.cpp 927301 
>   trunk/KDE/kdepim/kmail/kmail_part.rc 927301 
>   trunk/KDE/kdepim/kmail/kmfolderdialog.h 927301 
>   trunk/KDE/kdepim/kmail/kmfolderdialog.cpp 927301 
>   trunk/KDE/kdepim/kmail/kmmainwidget.h 927301 
>   trunk/KDE/kdepim/kmail/kmmainwidget.cpp 927301 
>   trunk/KDE/kdepim/kmail/kmmainwin.rc 927301 
> 
> Diff: http://reviewboard.kde.org/r/48/diff
> 
> 
> Testing
> -------
> 
> Built KMail from trunk with these patches, checked operation of all functions.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/