[Kde-pim] Review Request: Warn if a mail is sent to too many recipients

[Allen Winter]

> On 2009-02-20 05:11:20, Allen Winter wrote:
> > branches/kdepim/enterprise/kdepim/kmail/kmcomposewin.cpp, line 4356
> > <http://reviewboard.kde.org/r/133/diff/1/?file=837#file837line4356>
> >
> >     thomas will yell at you about coding style.  in kdepim, we put the opening brace on the same lin e with the 'if'.
> 
>  wrote:
>     It is a wish only. :) Both cases are present in that very same file.

yep.  we has been trying to unify to one style for a long time.  slow going.


> On 2009-02-20 05:11:20, Allen Winter wrote:
> > branches/kdepim/enterprise/kdepim/kmail/kmail.kcfg, line 344
> > <http://reviewboard.kde.org/r/133/diff/1/?file=835#file835line344>
> >
> >     please add a <tooltip> and a <whatsthis>
> 
>  wrote:
>     Makes sense, the place from where I copied this part didn't have the tooltip/whatsthis (a few lines above). ;)

yep.  we are missing *hundreds* of tooltips and whatsthis in kmail.  


> On 2009-02-20 05:11:20, Allen Winter wrote:
> > branches/kdepim/enterprise/kdepim/kmail/configuredialog.cpp, line 2646
> > <http://reviewboard.kde.org/r/133/diff/1/?file=833#file833line2646>
> >
> >     I wonder if a max of 255 is enough?
> 
>  wrote:
>     Well, i cannot imagine somebody wanting this warning only if he sends it to 1000+ recipients, but not to 999. :) But of course, I can increase it.

good point. 255 does sound like a reasonable number then.


- Allen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/133/#review194
-----------------------------------------------------------


On 2009-02-20 04:57:56, Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/133/
> -----------------------------------------------------------
> 
> (Updated 2009-02-20 04:57:56)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Implement https://www.intevation.de/roundup/kolab/issue3377 , add a warning if there are too many recipients. The warning can be turned off and the threshold number is user configurable.
> 
> 
> Diffs
> -----
> 
>   branches/kdepim/enterprise/kdepim/kmail/configuredialog.cpp 928827 
>   branches/kdepim/enterprise/kdepim/kmail/configuredialog_p.h 928827 
>   branches/kdepim/enterprise/kdepim/kmail/kmail.kcfg 928827 
>   branches/kdepim/enterprise/kdepim/kmail/kmcomposewin.h 928827 
>   branches/kdepim/enterprise/kdepim/kmail/kmcomposewin.cpp 928827 
> 
> Diff: http://reviewboard.kde.org/r/133/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andras
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/