[Kde-pim] Review Request: Warn if a mail is sent to too many recipients

[Ingo Klöcker]

On Friday 20 February 2009, Allen Winter wrote:
> > On 2009-02-20 05:11:20, Allen Winter wrote:
> > > branches/kdepim/enterprise/kdepim/kmail/kmcomposewin.cpp, line
> > > 4356
> > > <http://reviewboard.kde.org/r/133/diff/1/?file=837#file837line435
> > >6>
> > >
> > >     thomas will yell at you about coding style.  in kdepim, we
> > > put the opening brace on the same lin e with the 'if'.
> >
> >  wrote:
> >     It is a wish only. :) Both cases are present in that very same
> > file.
>
> yep.  we has been trying to unify to one style for a long time.  slow
> going.
>
> > On 2009-02-20 05:11:20, Allen Winter wrote:
> > > branches/kdepim/enterprise/kdepim/kmail/kmail.kcfg, line 344
> > > <http://reviewboard.kde.org/r/133/diff/1/?file=835#file835line344
> > >>
> > >
> > >     please add a <tooltip> and a <whatsthis>
> >
> >  wrote:
> >     Makes sense, the place from where I copied this part didn't
> > have the tooltip/whatsthis (a few lines above). ;)
>
> yep.  we are missing *hundreds* of tooltips and whatsthis in kmail.
>
> > On 2009-02-20 05:11:20, Allen Winter wrote:
> > > branches/kdepim/enterprise/kdepim/kmail/configuredialog.cpp, line
> > > 2646
> > > <http://reviewboard.kde.org/r/133/diff/1/?file=833#file833line264
> > >6>
> > >
> > >     I wonder if a max of 255 is enough?
> >
> >  wrote:
> >     Well, i cannot imagine somebody wanting this warning only if he
> > sends it to 1000+ recipients, but not to 999. :) But of course, I
> > can increase it.
>
> good point. 255 does sound like a reasonable number then.

255 is a weird number from a non-computer-scientist-user perspective. 
Please, make it 250 (or 100 or 200 or 500).


Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20090225/4b72ebf6/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/