[Kde-pim] Review Request: Fix KMail compilation on OSes w/o PATH_MAX

Pino Toscano pino at kde.org
Sat Dec 19 15:00:46 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2393/
-----------------------------------------------------------

(Updated 2009-12-19 15:00:46.549850)


Review request for KDE PIM.


Changes
-------

Second version, now using QDir API instead of C stdlib.


Summary
-------

There are OSes (eg GNU/Hurd) with no PATH_MAX defined (as not being POSIX).

The proposed change adds a way to get the current directory name using a glibc-specificy way, get_current_dir_name(), taking care of freeing the buffer after the usage.

It should change nothing for glibc toolchains with PATH_MAX defined (Linux, etc).


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/kmfoldermaildir.cpp 1063153 

Diff: http://reviewboard.kde.org/r/2393/diff


Testing
-------

It compiles on current trunk under GNU/Linux, and under GNU/Hurd.


Thanks,

Pino

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list