[Kde-pim] Review Request: Fix KMail compilation on OSes w/o PATH_MAX

Kevin Krammer kevin.krammer at gmx.at
Thu Dec 17 10:32:29 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2393/#review3445
-----------------------------------------------------------


Can you check whether QDir::current() or QDir::currentPath() can be used instead?
My guess would be that the code is from a time where that wasn't available yet and didn't need changing until now

- Kevin


On 2009-12-16 21:10:37, Pino Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2393/
> -----------------------------------------------------------
> 
> (Updated 2009-12-16 21:10:37)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> There are OSes (eg GNU/Hurd) with no PATH_MAX defined (as not being POSIX).
> 
> The proposed change adds a way to get the current directory name using a glibc-specificy way, get_current_dir_name(), taking care of freeing the buffer after the usage.
> 
> It should change nothing for glibc toolchains with PATH_MAX defined (Linux, etc).
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmfoldermaildir.cpp 1063019 
> 
> Diff: http://reviewboard.kde.org/r/2393/diff
> 
> 
> Testing
> -------
> 
> It compiles on current trunk under GNU/Linux, and under GNU/Hurd.
> 
> 
> Thanks,
> 
> Pino
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list