[Kde-pim] Review Request: input.cpp:248: warning: unused parameter 'mode'

Thomas McGuire mcguire at kde.org
Sat Dec 19 15:32:13 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2247/#review3462
-----------------------------------------------------------



/trunk/KDE/kdepim/kleopatra/utils/input.cpp
<http://reviewboard.kde.org/r/2247/#comment2765>

    Again, introducing a warning after removing another is not that helpful.
    
    For properly fixing this, you should look at the places where dateFromClipboard() is called, and at the QClipboard documentation, and then see what the best resolution would be.


- Thomas


On 2009-11-20 18:52:29, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2247/
> -----------------------------------------------------------
> 
> (Updated 2009-11-20 18:52:29)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/kleopatra/utils/input.cpp:248: warning: unused parameter 'mode'
> 
> at
> dataFromClipboard
> 
> my proposal: add Q_UNUSED( )
> see: input-gm-106.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kleopatra/utils/input.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2247/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list