[Kde-pim] Review Request: certifycertificatecommand.cpp:145: warning: unused parameter 'on'

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2238/#review3482
-----------------------------------------------------------


As with the other review requests, replacing a warning with a #warning doesn't reduce the amount of warnings :)

Each instance of unused warnings needs to be examined more closely, you have to check the code if the unused parameters are bugs, not implemented code or some other thing.

- Thomas


On 2009-11-20 17:47:09, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2238/
> -----------------------------------------------------------
> 
> (Updated 2009-11-20 17:47:09)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/kleopatra/commands/certifycertificatecommand.cpp:145: warning: unused parameter 'on'
> /.../kdepim/kleopatra/commands/certifycertificatecommand.cpp:149: warning: unused parameter 'on'
> /.../kdepim/kleopatra/commands/certifycertificatecommand.cpp:153: warning: unused parameter 'signer'
> 
> my proposal: add some Q_UNUSED( )
> see: certifycertificatecommand-gm-96.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kleopatra/commands/certifycertificatecommand.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2238/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/